[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 14 05:46:04 PDT 2017

arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM, with one request below:

Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:96
-  /// Finds an edit script that converts T1 to T2.
-  std::vector<Change> computeChanges(Mapping &M);
-  void printChangeImpl(raw_ostream &OS, const Change &Chg) const;
-  void printMatchImpl(raw_ostream &OS, const Match &M) const;
-  // Returns a mapping of identical subtrees.
-  Mapping matchTopDown() const;
+  NodeId getMapped(const std::unique_ptr<SyntaxTree::Impl> &Tree, NodeId Id) const {
+    if (&*Tree == &T1)
80 column violation, please re-format.


More information about the cfe-commits mailing list