[PATCH] D35364: [clang-tidy] Add a close-on-exec check on dup() in Android module.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 14 01:25:49 PDT 2017
hokein accepted this revision.
hokein added a comment.
Comment at: clang-tidy/android/CloexecCheck.h:91
+ /// Helper function to get the spelling of a particular argument.
+ StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult &Result,
+ int N) const;
> hokein wrote:
> > This method seems only be used in one check. Maybe move it to the implementation of that specific check? And you can make the private members `FuncBindingStr` and `FuncDeclBindingStr` to protected member.
> Actually, this method will be used in three checks.
Ah, ok. Sorry for missing it.
More information about the cfe-commits