[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

A few late comments.



================
Comment at: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-static-accessed-through-instance.rst:28-29
+
+  C::foo();
+  C::x;
+
----------------
This may be confusing as to whether the check removes the struct definition (and the definition of c1) or not.


================
Comment at: docs/clang-tidy/checks/readability-static-accessed-through-instance.rst:11
+
+Thefollowing code:
+
----------------
typo: "Thefollowing"


================
Comment at: test/clang-tidy/readability-static-accessed-through-instance.cpp:55
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member accessed through
+  // instance  [readability-static-accessed-through-instance]
+  // CHECK-FIXES: {{^}}  C::x;{{$}}
----------------
Line wrapping gone bad. I guess you can just remove the second line. Same below.


Repository:
  rL LLVM

https://reviews.llvm.org/D35937