[PATCH] D36171: AMDGPU: Use direct struct returns

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 12:44:33 PDT 2017


yaxunl added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:7386
+  bool isHomogeneousAggregateBaseType(QualType Ty) const override;
+  bool isHomogeneousAggregateSmallEnough(const Type *Base,
+                                         uint64_t Members) const override;
----------------
arsenm wrote:
> yaxunl wrote:
> > Please add descriptions for the above newly added functions.
> I prefer not to put descriptions on overrides since they will just be out of date with the declaration
Please add descriptions for the non-override functions and data members above.


https://reviews.llvm.org/D36171





More information about the cfe-commits mailing list