[PATCH] D35755: [Solaris] gcc toolchain handling revamp

Fedor Sergeev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 07:46:25 PDT 2017


fedor.sergeev marked an inline comment as not done.
fedor.sergeev added inline comments.


================
Comment at: lib/Driver/ToolChains/Gnu.h:253
 
+    void AddDefaultGCCPrefixes(const llvm::Triple &TargetTriple,
+                               SmallVectorImpl<std::string> &Prefixes,
----------------
aaron.ballman wrote:
> Might as well drop the `llvm::` since the namespace isn't used for `SmallVectorImpl`.
suggested change caused a build failure since Triple resolves into Toolchain::Triple data member, not to llvm::Triple.


https://reviews.llvm.org/D35755





More information about the cfe-commits mailing list