[PATCH] D36437: [clang] Get rid of "%T" expansions

[Kuba (Brecka) Mracek via Phabricator via cfe-commits]

kubamracek created this revision.
kubamracek added a project: clang.
Herald added subscribers: mehdi_amini, klimek.

The `%T` lit expansion expands to a common directory shared between all the tests in the same directory, which is unexpected and unintuitive, and more importantly, it's been a source of subtle race conditions and flaky tests.  In https://reviews.llvm.org/D35396, it was agreed that it would be best to simply ban `%T` and only keep `%t`, which is unique to each test.  When a test needs a temporary directory, it can just create one using `mkdir %t`.

This patch removes `%T` in clang.


Repository:
  rL LLVM

https://reviews.llvm.org/D36437

Files:
  test/Analysis/html-diags.c
  test/CoverageMapping/abspath.cpp
  test/Driver/compilation_database.c
  test/Driver/cpath.c
  test/Driver/darwin-ld-lto.c
  test/Driver/linker-opts.c
  test/Driver/output-file-cleanup.c
  test/Driver/parse-progname.c
  test/Driver/ps4-linker-non-win.c
  test/Driver/ps4-linker-win.c
  test/Driver/warning-options.cpp
  test/FixIt/fixit-include.c
  test/Format/style-on-command-line.cpp
  test/Lexer/case-insensitive-include-ms.c
  test/Lexer/case-insensitive-include-pr31836.sh
  test/Lexer/case-insensitive-include.c
  test/Lexer/case-insensitive-system-include.c
  test/Modules/crash-typo-correction-visibility.cpp
  test/Modules/modules-cache-path-canonicalization.m
  test/PCH/case-insensitive-include.c
  test/PCH/include-timestamp.cpp
  test/Preprocessor/cuda-types.cu
  test/Tooling/clang-diff-basic.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36437.110113.patch
Type: text/x-patch
Size: 35097 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170808/b312a6b5/attachment-0001.bin>