[PATCH] D36397: [clangd] Fixed a data race.

[Manuel Klimek via Phabricator via cfe-commits]

klimek added a comment.

In https://reviews.llvm.org/D36397#833890, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D36397#833883, @klimek wrote:
>
> > Tests?
>
>
> TSAN does not catch this (as it's a logical error) and it requires a rather bizarre timing of file reparses to trigger.
>  I couldn't come up with an example that would reproduce this.


Yea, we'll probably want to add a "smash it hard with parallel" requests kind of test to catch these things. You're right, there is probably not a better solution for this specific bug.


https://reviews.llvm.org/D36397