[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 6 21:50:49 PDT 2017


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:5742
+// effect of performing a trivial copy of the type.
+bool Sema::CanPassInRegisters(CXXRecordDecl *D) {
+  if (D->isDependentType())
----------------
This should probably be called something like "computeCanPassInRegisters" to discourage other code from calling it directly.

It should also just be a static function in this file unless it needs to be a member for some access-control reason.


https://reviews.llvm.org/D35056





More information about the cfe-commits mailing list