[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 4 06:25:43 PDT 2017


yaxunl marked 10 inline comments as done.
yaxunl added inline comments.


================
Comment at: include/clang/Basic/SyncScope.h:21
+/// \brief Defines the synch scope values used by the atomic builtins and
+/// expressions
+enum class SyncScope {
----------------
rjmccall wrote:
> If the numeric values here were chosen to align with the arguments to some runtime function, that's important to leave as a comment.
I have added the comments and updated the review.. On the Phabricator web page, it may take a bit effort to find it since it is interleaved with reviewers' comments.


https://reviews.llvm.org/D28691





More information about the cfe-commits mailing list