[PATCH] D36150: [clangd] LSP extension to switch between source/header file

[Marc-Andre Laperle via Phabricator via cfe-commits]

malaperle added inline comments.


================
Comment at: clangd/ProtocolHandlers.cpp:260
+  Dispatcher.registerHandler(
+      "textDocument/switchSourceHeader",
+      llvm::make_unique<SwitchSourceHeaderHandler>(Out, Callbacks));
----------------
ilya-biryukov wrote:
> ilya-biryukov wrote:
> > I don't see this method in the [[ https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md | LSP spec ]].
> > Is this some kind of extension?
> > 
> > Could you add some comments on that with pointers to proposal/explanation of where this extension is used?
> This comment was not addressed, probably marked as 'Done' by accident.
> Is this some kind of extension?

It's briefly mentioned in the summary but could use some more detail.
The first client to use it is Theia but I wonder if it would be easy to add it to the VS Code extension, as an example.


https://reviews.llvm.org/D36150