[PATCH] D36261: [clangd] Use multiple working threads in clangd.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 06:18:18 PDT 2017


ilya-biryukov added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:69
+  SchedulingOptions SchedOpts =
+      !RunSynchronously ? SchedulingOptions::RunOnWorkerThreads(ThreadsCount)
+                        : SchedulingOptions::RunOnCallingThread();
----------------
krasimir wrote:
> Consider inverting this condition.
Thanks, good point. I also like non-negated conditions more.
That code was removed in the updated version, though.


https://reviews.llvm.org/D36261





More information about the cfe-commits mailing list