[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

[Simon Atanasyan via Phabricator via cfe-commits]

atanasyan added inline comments.


================
Comment at: include/clang/Driver/Options.td:2065
+def mno_uninit_const_in_rodata : Flag<["-"], "mno-uninit-const-in-rodata">,
+  Group<m_Group>, HelpText<"Do not Place uninitialized constants in the "
+                           "read-only data section instead of the common"
----------------
s/Place/place/


================
Comment at: lib/Driver/ToolChains/Clang.cpp:1523
+          CmdArgs.push_back("-muninit-const-in-rodata");
+          A->claim();
+        }
----------------
What's happened if the `-muninit-const-in-rodata` is used without `-membedded-data`? Will the compiler shows a warning about unused command line option?


https://reviews.llvm.org/D35917