[libcxx] r309881 - Rename a couple variables to eliminate a shadow warning. No functionality change

Blitz Rakete via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 2 14:19:33 PDT 2017


Instead of creating two variables, wouldn't it be better to just remove the
second definition and clear m_ec? You don't need to use both error codes
side by side, as the second usage of m_ec occurs after the first one is
finished. So you could remove the second definition and call clear() on it,
to reset it. I think that way is clearer then introducing one new variable,
no?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170802/803b5a87/attachment.html>


More information about the cfe-commits mailing list