[PATCH] D36186: [clang-diff] Improve and test getNodeValue

Johannes Altmanninger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 2 14:14:07 PDT 2017


johannes added inline comments.


================
Comment at: test/Tooling/clang-diff-ast.cpp:32
+
+// CHECK: TypedefDecl: nat;unsigned int;(
+typedef unsigned nat;
----------------
klimek wrote:
> For my curiosity: why are there semicolons here? Is the format documented somewhere?
To avoid collisions (the value should be unique per TypedefDecl in this example), the second one is unnecessary I guess. It is not documented, If it works out I want to move to StmtDataCollector for node comparison and keep these just for visualisation / debugging.


https://reviews.llvm.org/D36186





More information about the cfe-commits mailing list