r309496 - Improve readability of CXX method overrides list

[David Blaikie via cfe-commits]

Test coverage?

On Sun, Jul 30, 2017 at 5:52 AM Lenar Safin via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: lll
> Date: Sat Jul 29 13:42:58 2017
> New Revision: 309496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309496&view=rev
> Log:
> Improve readability of CXX method overrides list
>
> Summary:
> Separate CXX method overrides list entries with commas.
>
> Reviewers: lhames
>
> Reviewed By: lhames
>
> Subscribers: llvm-commits
>
> Differential Revision: https://reviews.llvm.org/D35800
>
>
> Modified:
>     cfe/trunk/lib/AST/ASTDumper.cpp
>
> Modified: cfe/trunk/lib/AST/ASTDumper.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=309496&r1=309495&r2=309496&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/AST/ASTDumper.cpp (original)
> +++ cfe/trunk/lib/AST/ASTDumper.cpp Sat Jul 29 13:42:58 2017
> @@ -1184,7 +1184,7 @@ void ASTDumper::VisitFunctionDecl(const
>           I != E; ++I)
>        dumpCXXCtorInitializer(*I);
>
> -  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D))
> +  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D)) {
>      if (MD->size_overridden_methods() != 0) {
>        auto dumpOverride =
>          [=](const CXXMethodDecl *D) {
> @@ -1199,11 +1199,14 @@ void ASTDumper::VisitFunctionDecl(const
>          dumpOverride(*FirstOverrideItr);
>          for (const auto *Override :
>                 llvm::make_range(FirstOverrideItr + 1,
> -                                MD->end_overridden_methods()))
> +                                MD->end_overridden_methods())) {
> +          OS << ", ";
>            dumpOverride(Override);
> +        }
>          OS << " ]";
>        });
>      }
> +  }
>
>    if (D->doesThisDeclarationHaveABody())
>      dumpStmt(D->getBody());
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170731/c77d1969/attachment.html>