[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 28 09:55:49 PDT 2017


Quuxplusone accepted this revision.
Quuxplusone added a comment.

> But if I'm overseeing reasons to issue a warning in this case, we could add an analogue of `-Wshadow-uncaptured-local` for this case. WDYT?

I still think "any warning" is a marginally better UX than "no warning" on the particular code in question; but of course I defer to Reid/Richard/GCC on the practicalities. Adding a new warning option might not be worth the trouble. :)


https://reviews.llvm.org/D35941





More information about the cfe-commits mailing list