[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

[Diana Picus via Phabricator via cfe-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

Looks entirely mechanical, I don't see any problem with it (just a couple of nits).



================
Comment at: lib/Basic/Targets/AArch64.cpp:94
          llvm::AArch64::parseCPUArch(Name) !=
-             static_cast<unsigned>(llvm::AArch64::ArchKind::AK_INVALID);
+         llvm::AArch64::ArchKind::INVALID;
 }
----------------
My eyes might be deceiving me, but did you run clang-format?


================
Comment at: lib/Driver/ToolChains/Darwin.cpp:71
   const llvm::Triple::ArchType Arch = getArchTypeForMachOArchName(Str);
-  unsigned ArchKind = llvm::ARM::parseArch(Str);
+  llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Str);
   T.setArch(Arch);
----------------
Nitpick: The rename seems unnecessary (and anyway the file is inconsistent between Arch, ArchKind and AK).


https://reviews.llvm.org/D35884