[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.
Alexey Bader via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 27 07:07:18 PDT 2017
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
Thanks!
Overall the patch looks good, but I would suggest splitting it into three commits (as they seems to be independent):
1. [OpenCL] Check that cl_khr_subgroups pragma is enabled if respective extension is used.
2. [OpenCL] Add support for missing sub_group functions.
3. [OpenCL] Fix return type for reserve pipe built-ins.
Please, add a regression test for the part #3.
You might also review this patch with @Anastasia (OpenCL code owner).
================
Comment at: Sema/SemaChecking.cpp:685-689
+ // Since return type of reserve_read/write_pipe built-in function is
+ // reserve_id_t, which is not defined in the builtin def file , we used int
+ // as return type and need to override the return type of these functions.
+ Call->setType(S.Context.OCLReserveIDTy);
+
----------------
This change is not covered with regression tests.
https://reviews.llvm.org/D33945
More information about the cfe-commits
mailing list