[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

Chandler Carruth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 27 02:40:36 PDT 2017


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM with a tiny tweak below.

Would be good to add a test that this flag is being honored, either in this patch or in a follow-up.



================
Comment at: lib/CodeGen/BackendUtil.cpp:862-863
+    PGOOpt = PGOOptions("", "", "", false, true);
+  else
+    PGOOpt = None;
 
----------------
No need for this? The optional should be disengaged by default when constructed as you do above.


https://reviews.llvm.org/D35746





More information about the cfe-commits mailing list