[PATCH] D34158: For standards compatibility, preinclude <stdc-predef.h> if the file is available

Blower, Melanie via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 24 09:58:32 PDT 2017


@jyknight I've removed the check on nostdinc.  AFAIK, I've addressed all the feedback which I've received on the patch, is it OK to commit?  --Melanie

-----Original Message-----
From: James Y Knight via Phabricator [mailto:reviews at reviews.llvm.org] 
Sent: Monday, July 10, 2017 11:57 AM
To: Blower, Melanie <melanie.blower at intel.com>; zhangshengbin at huawei.com; olivier.jg at gmail.com; kalinichev.so.0 at gmail.com; kfunk at kde.org; mail at milianw.de; Keane, Erich <erich.keane at intel.com>; Hahnfeld at itc.rwth-aachen.de; mgorny at gentoo.org; fedor.sergeev at oracle.com; richard at metafoo.co.uk; renato.golin at linaro.org
Cc: jyknight at google.com; ibiryukov at google.com; cfe-commits at lists.llvm.org; klimek at google.com; simon.dardis at imgtec.com; anastasia.stulova at arm.com; arichardson.kde at gmail.com
Subject: [PATCH] D34158: For standards compatibility, preinclude <stdc-predef.h> if the file is available

jyknight added a comment.

This version is still disabling upon -nostdinc, which doesn't make sense to me.

You didn't remove that, nor respond explaining why you think it does make sense?


https://reviews.llvm.org/D34158





More information about the cfe-commits mailing list