[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

[Yuka Takahashi via Phabricator via cfe-commits]

yamaguchi added inline comments.


================
Comment at: llvm/lib/Option/OptTable.cpp:240
       if (StringRef(S).startswith(Cur))
-        Ret.push_back(S);
+        Ret.push_back(S + "\t" + std::string(StringRef(In.HelpText)));
     }
----------------
ruiu wrote:
> I believe
> 
>   Ret.push_back(S + "\t" + In.HelpText);
> 
> should just work.
Thanks for pointing out, but I think it segfaults because In.HelpText might be a nullptr.
So I update diff to check if it's nullptr or not, which seems more obvious.


https://reviews.llvm.org/D35759