[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

[Nico Weber via Phabricator via cfe-commits]

thakis created this revision.

MSVC2017 update 3 produces a clang that crashes when compiling clang. Disabling optimizations for StmtProfiler::VisitCXXOperatorCallExpr() makes the crash go away.

Patch from Bruce Dawson <brucedawson at chromium.org>!


https://reviews.llvm.org/D35757

Files:
  lib/AST/StmtProfile.cpp


Index: lib/AST/StmtProfile.cpp
===================================================================
--- lib/AST/StmtProfile.cpp
+++ lib/AST/StmtProfile.cpp
@@ -1364,6 +1364,13 @@
   llvm_unreachable("Invalid overloaded operator expression");
 }
 
+#if defined(_MSC_VER) && _MSC_VER == 1911
+// Work around https://developercommunity.visualstudio.com/content/problem/84002/clang-cl-when-built-with-vc-2017-crashes-cause-vc.html
+// MSVC 2017 update 3 miscompiles this function, and a clang built with it
+// will crash in stage 2 of a bootstrap build.
+#pragma optimize("", off)
+#endif
+
 void StmtProfiler::VisitCXXOperatorCallExpr(const CXXOperatorCallExpr *S) {
   if (S->isTypeDependent()) {
     // Type-dependent operator calls are profiled like their underlying
@@ -1396,6 +1403,10 @@
   ID.AddInteger(S->getOperator());
 }
 
+#if defined(_MSC_VER) && _MSC_VER == 1911
+#pragma optimize("", on)
+#endif
+
 void StmtProfiler::VisitCXXMemberCallExpr(const CXXMemberCallExpr *S) {
   VisitCallExpr(S);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35757.107771.patch
Type: text/x-patch
Size: 1008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170722/8f1a4b7c/attachment.bin>