[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 13:31:46 PDT 2017

erichkeane added a comment.

In https://reviews.llvm.org/D35701#817526, @echristo wrote:

> I'm going to say this ahead of time without looking into it "LGTM", but wait for ctopper (or someone else) to ack it for style etc since I'm unlikely to get to it any time shortly. :)
> Also, make sure to clang format all the files please. I'm assuming you have, but...
> -eric

Thanks!  I did 'clang-format' in advance, though I reverted 1 version of it (the big list it turned into single entries for some reason).  I'll wait for @craig.topper's finished.


More information about the cfe-commits mailing list