[PATCH] D35613: Add Support for Generic Reference Counting Annotations in RetainCountChecker

Malhar Thakkar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 02:26:19 PDT 2017

malhar1995 added inline comments.

Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2012
+      } else if (CurrV.getObjKind() == RetEffect::GenericC) {
+        if (Sym->getType().isNull()) {
+          os << " returns an object with a ";
NoQ wrote:
> I don't think this can happen. Symbols always have a type, see `isValidTypeForSymbol()`. These branches can be removed from the surrounding code as well.
So, you're saying `Sym->getType()` can never be NULL?
If so, do you want me to insert `assert(isValidTypeForSymbol(Sym->getType()))` instead? 



More information about the cfe-commits mailing list