[PATCH] D35338: Add the -fdestroy-globals flag

George Burgess IV via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 19:58:50 PDT 2017

george.burgess.iv added a comment.

Thanks for working on this!

One small drive-by nit for you. Same "no need to update the diff this very second" as vsk; I can't LGTM this with confidence.

(Also, in the future, please try to include context <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface> with your patch. Doing so makes reviewing it on Phab much easier. :) )

Comment at: include/clang/Frontend/CodeGenOptions.def:47
                                      ///< aliases to base ctors when possible.
+CODEGENOPT(DestroyGlobals, 1, 1) ///< -fdestroy-globals
 CODEGENOPT(DataSections      , 1, 0) ///< Set when -fdata-sections is enabled.
Nit: Please align the `///` with the above/below ones.


More information about the cfe-commits mailing list