[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

One minor revision, but otherwise looks great, thank you.



================
Comment at: lib/CodeGen/CodeGenModule.cpp:1166
+    if (!IsForDefinition)
+      getTargetCodeGenInfo().setTargetAttributes(FD, F, *this);
+  }
----------------
I think you should probably pass IsForDefinition to setTargetAttributes.  Targets may want to only set certain attributes on function definitions.


Repository:
  rL LLVM

https://reviews.llvm.org/D35479