[PATCH] D35038: [libunwind] Add a test harness

Manoj Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 14:57:22 PDT 2017


manojgupta added inline comments.


================
Comment at: test/lit.cfg:36
+else:
+    lit_config.fatal('Could not find libcxx test directory for test imports'
+                     ' in: %s' % libcxx_test_src_root)
----------------
jroelofs wrote:
> manojgupta wrote:
> > I do not have libcxx checked out since I am want to use only compiler-rt + libunwind to replace libgcc_s. This libcxx dependency  breaks this testing.
> This only requires that you check it out, not that you build it. Note that libcxxabi has the same constraint.
Checking out libcxx should not be a requirement since libunwind should be usable independently on libcxx.
Not sure if it can be compared to libcxxabi, since most people working on libcxx/libcxxabi will checkout both libcxx and libcxxabi.


https://reviews.llvm.org/D35038





More information about the cfe-commits mailing list