[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

Pirama Arumuga Nainar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 12:53:04 PDT 2017

pirama added inline comments.

Comment at: cmake/caches/Android-stage2.cmake:27
+  set(RUNTIMES_${target}-linux-android_CMAKE_ASM_FLAGS ${ANDROID_${target}_C_FLAGS} CACHE PATH "")
+  set(RUNTIMES_${target}-linux-android_CMAKE_BUILD_TYPE RELEASE CACHE STRING "")
+  set(RUNTIMES_${target}-linux-android_CMAKE_C_FLAGS ${ANDROID_${target}_C_FLAGS} CACHE PATH "")
Same comment as ASSERTIONS below.

Comment at: cmake/caches/Android-stage2.cmake:37
+  set(RUNTIMES_${target}-linux-android_COMPILER_RT_INCLUDE_TESTS OFF CACHE BOOL "")
+  set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
+  set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_THREADS OFF CACHE BOOL "")
Should we initialize it to LLVM_ENABLE_ASSERTIONS rather than defaulting to ON?  So assertions can be enabled/disabled for all targets with just one switch (and then over-ride with per-target flags, if necessary).


More information about the cfe-commits mailing list