[PATCH] D35519: Add SEMA checking to attribute 'target'

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 08:50:59 PDT 2017

erichkeane added a comment.

In https://reviews.llvm.org/D35519#813082, @echristo wrote:

> If you wouldn't mind I'd like to see this separated out a bit -
>  a) I think we can make the attribute info a struct rather than a pair as a simple change first
>  b) setCPU split
>  c) let's see where we are after that?
> Also the description makes it sound like you're adding support for the feature rather than fixing the terrible error diagnostics - or at least to my early morning brain. :)
> Also, one inline comment so far.
> Thanks!
> -eric

Caught me just in time :)

Sure, I can split this into a couple of patches.  I'll abandon this one and go from there.


More information about the cfe-commits mailing list