[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 18 00:05:29 PDT 2017

mgrang added a comment.

In https://reviews.llvm.org/D35529#812427, @mstorsjo wrote:

> Wouldn't it make more sense to set this by default within LLVM, where it's already enabled by default for darwin?
> Currently there's this code there:
>   AArch64Subtarget::AArch64Subtarget(const Triple &TT, const std::string &CPU,
>                                      const std::string &FS,
>                                      const TargetMachine &TM, bool LittleEndian)
>       : AArch64GenSubtargetInfo(TT, CPU, FS), ReserveX18(TT.isOSDarwin()),

Thanks for pointing this out. This certainly seems a cleaner way/place to do this. Lemme give it a shot.


More information about the cfe-commits mailing list