clang-format: Fix deref treated as binary op in throw

Erik Uhlmann via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 17 07:28:19 PDT 2017


I don’t have commit access, so I’d need you to check it in. Thanks for your help!

From: Manuel Klimek <klimek at google.com>
Date: Monday, July 17, 2017 at 03:31
To: Erik Uhlmann <euhlmann at vmware.com>, "cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
Subject: Re: clang-format: Fix deref treated as binary op in throw

LG, thanks for the patch. For next time, it helps to use phabricator to make people catch patches faster :)

Do you have commit access or do you need me to check it in?

On Thu, Jul 6, 2017 at 6:53 PM Erik Uhlmann via cfe-commits <cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>> wrote:
When dereferencing a pointer in a throw statement, clang-format assigns TT_BinaryOperator to the star token, so it gets formatted as:

throw * x;

With this change the above becomes

throw *x;

Bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665<https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.llvm.org_show-5Fbug.cgi-3Fid-3D33665&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig&m=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s&s=3S0gX68mvOabDGdTODcMBbmYJB4pHnUzRN3mNNwVGzc&e=>

Attached is a patch containing the fix.

_______________________________________________
cfe-commits mailing list
cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwMFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig&m=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s&s=TfTlgUj10Yo0COkFwEotZwRfb7Z5DnI_f8ENR3mpd3k&e=>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170717/da89f7aa/attachment.html>


More information about the cfe-commits mailing list