[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 14 03:38:23 PDT 2017


alexfh added inline comments.


================
Comment at: unittests/Tooling/DiagnosticsYamlTest.cpp:35-45
+TEST(DiagnosticsYamlTest, serializesDiagnostics) {
+  TranslationUnitDiagnostics TUD;
+  TUD.MainSourceFile = "path/to/source.cpp";
+
+  StringMap<Replacements> Fix1 = { 
+    { 
+      "path/to/source.cpp",  
----------------
Note: there's a bunch of trailing whitespace here and the formatting is off in a few places. git-clang-format fixed both issues, but it would be nice if you set up your editor properly or run clang-format yourself next time.

Same for the other CL, but there I had to also clean up trailing whitespace from yaml files as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D34404





More information about the cfe-commits mailing list