r307959 - Use getNameAsString instead of getName to get method names when dumping

Lang Hames via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 13 14:08:29 PDT 2017


Author: lhames
Date: Thu Jul 13 14:08:29 2017
New Revision: 307959

URL: http://llvm.org/viewvc/llvm-project?rev=307959&view=rev
Log:
Use getNameAsString instead of getName to get method names when dumping
overrides:  getName can fail if the decl's name isn't a simple identifier.

This is a more general replacement for the fix in r305860.


Modified:
    cfe/trunk/lib/AST/ASTDumper.cpp

Modified: cfe/trunk/lib/AST/ASTDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=307959&r1=307958&r2=307959&view=diff
==============================================================================
--- cfe/trunk/lib/AST/ASTDumper.cpp (original)
+++ cfe/trunk/lib/AST/ASTDumper.cpp Thu Jul 13 14:08:29 2017
@@ -1189,12 +1189,8 @@ void ASTDumper::VisitFunctionDecl(const
       auto dumpOverride =
         [=](const CXXMethodDecl *D) {
           SplitQualType T_split = D->getType().split();
-          OS << D << " " << D->getParent()->getName() << "::";
-          if (isa<CXXDestructorDecl>(D))
-            OS << "~" << D->getParent()->getName();
-          else
-            OS << D->getName();
-          OS << " '" << QualType::getAsString(T_split) << "'";
+          OS << D << " " << D->getParent()->getName() << "::"
+             << D->getNameAsString() << " '" << QualType::getAsString(T_split) << "'";
         };
 
       dumpChild([=] {




More information about the cfe-commits mailing list