[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Egor Churaev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 13 00:23:56 PDT 2017


echuraev added a comment.

In https://reviews.llvm.org/D35000#801132, @Anastasia wrote:

> In https://reviews.llvm.org/D35000#799705, @Anastasia wrote:
>
> > Btw, is there any reason to add testing specifically for half? Is there anything specific to half in the implementation of this?
>
>
> Trying to understand the reason for this change though...


Sorry for a delay in response. No it is not any reason to add testing specifically for half. We can also do the same tests for other data types. Here we just check that it is no any qualifiers in metadata.


https://reviews.llvm.org/D35000





More information about the cfe-commits mailing list