[PATCH] D34981: RecursiveASTVisitor should visit the nested name qualifiers in a template specialisation

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 15:11:57 PDT 2017


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

I haven't touched any AST code but this looks good to me: it's in line with what's done in TraverseRecordHelper and the test case is comprehensive.



================
Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:269
+TEST(RecursiveASTVisitor,
+     NestedNameSpecifiersForTemplateSpecializatoinsAreVisited) {
+  StringRef Source = R"(
----------------
Nit, 'specializations'


Repository:
  rL LLVM

https://reviews.llvm.org/D34981





More information about the cfe-commits mailing list