[PATCH] D34158: For standards compatibility, preinclude <stdc-predef.h> if the file is available

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 09:07:40 PDT 2017


hfinkel added a comment.

In https://reviews.llvm.org/D34158#803752, @jyknight wrote:

> This version is still disabling upon -nostdinc, which doesn't make sense to me.


I agree. If I pass -nostdinc, so that I then arrange include paths for my own libc headers, I'd then like to pick up the predef header from that library (if available). There's no clearly right answer for whether  `__STDC_NO_THREADS__` is defined, for example, regardless of whether we're using -nostdinc.

> You didn't remove that, nor respond explaining why you think it does make sense?




https://reviews.llvm.org/D34158





More information about the cfe-commits mailing list