[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 10 02:16:16 PDT 2017


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

Just noticed another couple of nits, otherwise looks good. Thanks!

Do you need me to commit the patch for you?



================
Comment at: clang-tidy/tool/run-clang-tidy.py:158
+                      help='Create a yaml file to store suggested fixes in, '
+                      'which can be applied with clang-apply-replacements')
   parser.add_argument('-j', type=int, default=0,
----------------
nit: Add a trailing period.


================
Comment at: clang-tidy/tool/run-clang-tidy.py:240
+  if args.export_fixes:
+    print 'Writing fixes to ' + args.export_fixes
+    merge_replacement_files(tmpdir, args.export_fixes)
----------------
nit: Add ` + '...'` at the end for consistency with other similar messages.


https://reviews.llvm.org/D31326





More information about the cfe-commits mailing list