[PATCH] D35180: Expose the Clang::QualType to llvm::Type conversion functions

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 9 19:35:51 PDT 2017


majnemer added inline comments.


================
Comment at: lib/CodeGen/CodeGenABITypes.cpp:71
+  assert(FD != nullptr && "Expected a non-null function declaration!");
+  llvm::Type* T = CGM.getTypes().ConvertFunctionType(FD->getType(), FD);
+
----------------
Pointers lean right.


================
Comment at: lib/CodeGen/CodeGenABITypes.cpp:73
+
+  if(auto FT = dyn_cast<llvm::FunctionType>(T))
+    return FT;
----------------
need a space between the `if` and the parenthesis.


https://reviews.llvm.org/D35180





More information about the cfe-commits mailing list