[PATCH] D35172: Keep the IdentifierInfo in the Token for alternative operator keyword

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

It looks like there are fewer special cases with this direction then our present one, though I worry that they'll be less obvious. On the whole, this seems like a improvement.



================
Comment at: lib/Lex/PPExpressions.cpp:242
   switch (PeekTok.getKind()) {
-  default:  // Non-value token.
+  default:
+    // If this token's spelling is a pp-identifier, check to see if it is
----------------
I'm concerned that this will do the wrong thing for a keyword operator that is not permitted in a pp expression, like and_eq. It seems safer to revert this change and instead add a isCPlusPlusOperatorKeyword check to the "if" condition above.


https://reviews.llvm.org/D35172