[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added inline comments.


================
Comment at: src/cxa_demangle.cpp:87
+
+class stream
+{
----------------
Doc
(same for non trivial APIs)


================
Comment at: src/cxa_demangle.cpp:125
+
+    typedef unsigned stream_position;
+
----------------
Doc


================
Comment at: src/cxa_demangle.cpp:173
+
+class node
+{
----------------
Doc


================
Comment at: src/cxa_demangle.cpp:239
+    virtual void print_left(stream& s) const = 0;
+    virtual void print_right(stream&) const {}
+
----------------
Why is one pure virtual and not the other? Why isn't the stream const?


================
Comment at: src/cxa_demangle.cpp:244
+    // Silence compiler warnings, this dtor will never be called.
+    virtual ~node() {}
+};
----------------
`= default;`


https://reviews.llvm.org/D35159