[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

Michael F. Herbst via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 7 01:10:03 PDT 2017


mfherbst added inline comments.


================
Comment at: run-clang-tidy.py:105
+      elif merged['MainSourceFile'] != content['MainSourceFile']:
+        # The values given for MainSourceFile are inconsistent.
+        # Just empty MainSourceFile blank:
----------------
alexfh wrote:
> This is going to be the case for each non-trivial invocation of this script. Do we need to keep `MainSourceFile` at all?
Good point. As it turns out clang-apply-replacement never uses the value afaik. The field needs to be around, however, since the definition of the replacements ``yaml`` format ( see ``clang/include/clang/Tooling/ReplacementsYaml.h``) makes it mandatory.


https://reviews.llvm.org/D31326





More information about the cfe-commits mailing list