[PATCH] D35061: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 6 10:10:01 PDT 2017


erik.pilkington added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:142
   if (Result == AR_NotYetIntroduced) {
+    if (AvoidAvailabilityChecks)
+      return;
----------------
arphaman wrote:
> erik.pilkington wrote:
> > Why are we doing this just for partials? Doesn't this also apply to unavailable/deprecated?
> We warned about the unavailable/deprecated protocols previously, so we should probably keep these warnings. The unguarded availability one is new, so we can drop it.
But this is strictly less diagnostics, dropping diagnostics for unavail/depr here won't break anything outside of clang tests. So if they don't make sense to emit, then there isn't any reason to keep them around.


Repository:
  rL LLVM

https://reviews.llvm.org/D35061





More information about the cfe-commits mailing list