[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 23:15:47 PDT 2017


Hahnfeld added a comment.

In https://reviews.llvm.org/D34888#799576, @gtbercea wrote:

> Does this also include the fixes in the following revision?
>
> https://reviews.llvm.org/D29905


Sorry, I wasn't aware of this revision and thought that it had long been committed. I just verified that the bug referenced in the summary is also fixed by my patch in https://reviews.llvm.org/D34888. However, I can't comment on whether this patch is still needed. Sorry for the conflicts if yes...

You probably should commit your patches earlier, you currently have 10 accepted revisions that have not yet been committed. This will also avoid complicated rebases and so on.


Repository:
  rL LLVM

https://reviews.llvm.org/D29905





More information about the cfe-commits mailing list