[PATCH] D34992: Emit static constexpr member as available_externally definition

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 16:14:55 PDT 2017


mehdi_amini added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2376
+    const VarDecl *InitDecl;
+    const Expr *InitExpr = D->getAnyInitializer(InitDecl);
+    if (InitExpr) {
----------------
ahatanak wrote:
> Does getAnyInitializer ever return a null pointer here when D is a c++11 constexpr?
That's a good question, I wouldn't expect so. I can try adding an assertion instead.
I guess @rsmith could confirm as well.


https://reviews.llvm.org/D34992





More information about the cfe-commits mailing list