[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 13:04:52 PDT 2017


gtbercea added inline comments.


================
Comment at: lib/Driver/Driver.cpp:564
+              auto &CudaTC =
+                  ToolChains[TT.str() + "/" + HostTC->getTriple().normalize()];
+              if (!CudaTC)
----------------
Hahnfeld wrote:
> The code above uses `HostTriple.str()`, maybe better align to this?
HostTriple is equivalent with HostTC->getTriple(). HostTC->getTriple() is only used once so no need for a local variable unless you want me to refactor the CUDA code above and take out HostTriple from within the if statement and then re0use HostTriple that way. I'd rather not make changes to the CUDA toolchain above.


https://reviews.llvm.org/D29658





More information about the cfe-commits mailing list