[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 5 09:57:10 PDT 2017


Anastasia added a comment.

Btw, is there any reason to add testing specifically for half? Is there anything specific to half in the implementation of this?



================
Comment at: test/CodeGenOpenCL/kernel-arg-info.cl:79
+kernel void foo6_2(global const volatile half * restrict globalconstvolatilehalfrestrictp,
+                   local half*localhalfp,
+                   local half *restrict localhalfrestrictp,
----------------
could you add space b/w half and *. Also could we format consistently below?


https://reviews.llvm.org/D35000





More information about the cfe-commits mailing list