[PATCH] D34329: [clang-diff] Initial implementation.

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 4 03:19:13 PDT 2017


arphaman added inline comments.


================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:385
+  }
+  int getSizeS() const { return RootIds.size(); }
+  NodeId getIdInRoot(SNodeId Id) const {
----------------
What's the purpose of the `S` prefix in the name of this method and a couple of other methods below? Can you replace it with something more descriptive or remove it altogether?


https://reviews.llvm.org/D34329





More information about the cfe-commits mailing list