[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333
Jennifer Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 30 17:19:29 PDT 2017
jyu2 added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:409
+ << (Ty->hasExceptionSpec() ? FD->getExceptionSpecSourceRange()
+ : FD->getSourceRange());
+ } else
> Underlining the entire function is probably not useful; I would just use `FD->getExceptionSpecSourceRange()` here -- that way you just won't get any highlighting if there isn't an explicit exception spec.
Good point. Changed.
More information about the cfe-commits