[PATCH] D34568: [Sema] Make BreakContinueFinder handle nested loops.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 16:48:12 PDT 2017

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

I'm not particularly happy with the number of different places where we duplicate the knowledge of how break/continue bind to enclosing loops, but fixing that seems beyond the scope of this change.

Comment at: lib/Sema/SemaStmt.cpp:1610
+        Visit(End);
+    }
In CodeGen, we don't evaluate the condition within the continue/break scope of the loop... but I'm pretty sure that doesn't matter because only the range statement can contain a break or continue anyway.



More information about the cfe-commits mailing list