[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 30 14:09:38 PDT 2017

rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.

Comment at: lib/Sema/SemaDecl.cpp:13693-13694
+              // passes the structural compatibility check in C11 6.2.7/1.
+              bool AllowODR = getLangOpts().CPlusPlus || getLangOpts().ObjC1 ||
+                              getLangOpts().C11;
               NamedDecl *Hidden = nullptr;
I don't think this should require C11 -- in C89 the corresponding rule is in, so the rule exists in all languages that Clang supports.


More information about the cfe-commits mailing list